W-18672586 - Update Error Component with Chakra v3#2776
W-18672586 - Update Error Component with Chakra v3#2776alexvuong merged 5 commits intofeature/chakra-ui-upgrade-v3from
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
alexvuong
changed the title
| // }, | ||
| { | ||
| path: [ | ||
| config.pages.ResetPassword && config.pages.ResetPassword.path, |
There was a problem hiding this comment.
We've fixed this page, I re-enabled it
|
Cleaned up the PR according to lint messages |
| import {ADD_FILTER, REMOVE_FILTER} from '../../../pages/product-list/partials/refinements-utils' | ||
|
|
||
| const RadioRefinement = ({filter, value, toggleFilter, isSelected}) => { | ||
| const RadioRefinement = ({value, isSelected}) => { |
There was a problem hiding this comment.
We are not using filter and toggleFilter props in the code
|
|
||
| import React from 'react' | ||
| import {Heading, Stack, Separator, Accordion} from '@chakra-ui/react' | ||
| import {Heading, Stack, Accordion} from '@chakra-ui/react' |
There was a problem hiding this comment.
removed unused Component
| Center, | ||
| Button, | ||
| Flex, | ||
| Heading, |
There was a problem hiding this comment.
unused components
| Dialog, | ||
| HStack, | ||
| IconButton, | ||
| Flex, |
| variant="unstyled" | ||
| onClick={() => history.push('/')} | ||
| /> | ||
| // We need to use window.location.href here rather than history |
There was a problem hiding this comment.
Make sense to me. Just curious, was it working before?
There was a problem hiding this comment.
you meant if history was working before? I suppose it was not, so we changed to use window.location.
…or-comp # Conflicts: # packages/extension-chakra-storefront/src/components/with-layout/with-layout.tsx # packages/extension-chakra-storefront/src/setup-app.tsx
| pages: {ProductList: productListConfig}, | ||
| maxCacheAge: MAX_CACHE_AGE, | ||
| staleWhileRevalidate: STALE_WHILE_REVALIDATE, | ||
| search: searchConfig |
There was a problem hiding this comment.
I take it we weren't using this searchConfig?
There was a problem hiding this comment.
yes, we don't need this data in this page anymore
* Update Error component with chakra v3
4 participants
Description
This PR update Error component with Chakra v3
Desktop
mobile
Types of Changes
Changes
How to Test-Drive This PR
throw new Error ('test')at render function of any component in the appChecklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization